-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove file if it exists before creating new one #15186
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #15186 +/- ##
=======================================
Coverage 67.34% 67.35%
=======================================
Files 1021 1021
Lines 88118 88121 +3
Branches 2297 2297
=======================================
+ Hits 59347 59350 +3
Misses 24351 24351
Partials 4420 4420
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@lucasmrod @mostlikelee @getvictor I was thinking about automated testing approaches for this fix, but haven't settled on anything satisfactory. The current packaging tests are not extensive fwiw, so maybe we don't need a new test for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
How about testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We might also need to test RPM packages (probably has the same issue?)
- Adding the unit test.
4bd2012
to
0aaa82a
Compare
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/
ororbit/changes/
.See Changes files for more information.