Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API endpoints that support os_setttings filter to include Windows MDM profiles status #15188

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

gillespi314
Copy link
Contributor

Issue #14424

TODO:

  • Expand integration tests for summary endpoint with more Windows profiles (to be included in follow up PR)

  • Load test?

  • Changes file added for user-visible changes in changes/ or orbit/changes/.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

  • Added/updated tests

  • Manual QA for all new/changed functionality

@gillespi314 gillespi314 requested a review from a team as a code owner November 17, 2023 17:57
'verifying'
ELSE
'verified'
END)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to mirror the hosts filter. This additional case isn't strictly needed here because unlike the host filter this particular query is only used for the summary when we expect to have a bitlocker status (so we can go straight to the final else in this particular case), but I went ahead and included it here for consistency and future clarity.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (f24cc15) 59.04% compared to head (8d59507) 59.20%.
Report is 2 commits behind head on main.

Files Patch % Lines
server/datastore/mysql/microsoft_mdm.go 95.15% 10 Missing and 4 partials ⚠️
server/service/testing_client.go 10.00% 8 Missing and 1 partial ⚠️
server/service/mdm.go 68.42% 4 Missing and 2 partials ⚠️
server/service/microsoft_mdm.go 50.00% 4 Missing and 2 partials ⚠️
server/service/apple_mdm.go 82.75% 4 Missing and 1 partial ⚠️
server/service/client_profiles.go 0.00% 4 Missing ⚠️
server/datastore/mysql/hosts.go 97.05% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15188      +/-   ##
==========================================
+ Coverage   59.04%   59.20%   +0.16%     
==========================================
  Files         965      965              
  Lines       81985    82394     +409     
  Branches     2277     2277              
==========================================
+ Hits        48409    48784     +375     
- Misses      29848    29870      +22     
- Partials     3728     3740      +12     
Flag Coverage Δ
backend 59.85% <90.18%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@roperzh roperzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed on following up with integration tests as time allows, LGTM!

@gillespi314 gillespi314 merged commit 3399b31 into main Nov 17, 2023
@gillespi314 gillespi314 deleted the 14424-hosts-filter-windows-profiles-status branch November 17, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants