Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI – Fix bug with line breaks in example command #15331

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

jacobshandling
Copy link
Contributor

@jacobshandling jacobshandling commented Nov 28, 2023

Addresses #14970

Command fails for correct reason (no real path provided), instead of reading it as multiple commands due to line breaks:

Screenshot 2023-11-27 at 4 27 21 PM
  • Changes file added for user-visible changes in changes/
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd9236b) 67.07% compared to head (6ecb6fd) 67.01%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15331      +/-   ##
==========================================
- Coverage   67.07%   67.01%   -0.07%     
==========================================
  Files        1020     1020              
  Lines       88113    88113              
  Branches     2298     2298              
==========================================
- Hits        59104    59051      -53     
- Misses      24617    24658      +41     
- Partials     4392     4404      +12     
Flag Coverage Δ
frontend 52.39% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lukeheath lukeheath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@jacobshandling jacobshandling merged commit eaa124e into main Dec 1, 2023
@jacobshandling jacobshandling deleted the 14970-line-break branch December 1, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants