API design: Target hosts by serial number #15344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- API changes for #14748 - Document `hardware_serial` name to be consistent w/ `hardware_serial` parameter in hosts endpoints
noahtalerman
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Closed
2 tasks
gillespi314
reviewed
Nov 28, 2023
| @@ -2410,7 +2410,7 @@ Returns the information of the host specified using the `uuid`, `osquery_host_id | |||
|
|
|||
There was a problem hiding this comment.
Lines 2404-2405 above should also include a reference to hardware_serial
noahtalerman
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
noahtalerman
changed the title
noahtalerman
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
noahtalerman
changed the title
noahtalerman
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
|
This PR is now ready for review because the story (#14748) was shipped in 4.42 |
rachaelshaw
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fleetctl run-scriptandfleetctl mdm run-commandcommands #14748hardware_serialname to be consistent w/hardware_serialparameter in hosts endpoints