Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet Calendar feature: Updates to manage automations modal #17652

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Mar 14, 2024

Issue

Cerra #17540
Part of #17230

Description

  • Rename to Other workflows modal
  • Remove example ticket and example payload modal and make it inline
  • Move policies to the bottom
  • Move description and external link to the bottom

Screenrecording

https://www.loom.com/share/1f23571086e74161b12dcf77e6dcb3dd?sid=0fb97572-f6cd-4e5e-bb95-01725adf0cc5

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.29%. Comparing base (1865933) to head (ec963e4).

❗ Current head ec963e4 differs from pull request most recent head c525711. Consider uploading reports for the commit c525711 to get more accurate results

Additional details and impacted files
@@                   Coverage Diff                   @@
##           17230-calendar-feature   #17652   +/-   ##
=======================================================
  Coverage                   65.29%   65.29%           
=======================================================
  Files                        1200     1200           
  Lines                      109166   109166           
  Branches                     2574     2574           
=======================================================
  Hits                        71277    71277           
  Misses                      32480    32480           
  Partials                     5409     5409           
Flag Coverage Δ
frontend 51.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@getvictor getvictor force-pushed the 17230-calendar-feature branch from 332c27b to 5da6d50 Compare March 15, 2024 00:15
@RachelElysia RachelElysia force-pushed the calendar-automations-modal branch from 7f56e1a to ddea275 Compare March 15, 2024 13:48
@RachelElysia RachelElysia force-pushed the calendar-automations-modal branch from 2c5c9d6 to c4165cb Compare March 15, 2024 14:06
@RachelElysia RachelElysia marked this pull request as ready for review March 15, 2024 14:06
@RachelElysia RachelElysia requested a review from a team as a code owner March 15, 2024 14:06
@getvictor getvictor force-pushed the 17230-calendar-feature branch from dd6c424 to a3118c7 Compare March 19, 2024 17:28
@RachelElysia RachelElysia requested a review from a team as a code owner March 19, 2024 17:28
@RachelElysia RachelElysia dismissed jacobshandling’s stale review March 20, 2024 16:45

ready for re-review

@RachelElysia RachelElysia removed the request for review from a team March 20, 2024 20:03
@RachelElysia RachelElysia merged commit 6f6e077 into 17230-calendar-feature Mar 20, 2024
4 checks passed
@RachelElysia
Copy link
Member Author

This feature removes the bug filed on 17620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants