Fleet UI: Add reset results warning for modifying platform or min osquery version #17663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait on solution decided for #17662 before continuing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 17018-reset-query-report #17663 +/- ##
=========================================================
Coverage 65.59% 65.59%
=========================================================
Files 1191 1191
Lines 107547 107564 +17
Branches 2566 2582 +16
=========================================================
+ Hits 70543 70557 +14
- Misses 31646 31649 +3
Partials 5358 5358
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RachelElysia
commented
Mar 19, 2024
| @@ -638,12 +638,32 @@ const EditQueryForm = ({ | |||
| "differential_ignore_removals", | |||
| ].includes(lastEditedQueryLoggingType); | |||
|
|
|||
| // Note: The backend is not resetting the query reports with equivalent platform strings | |||
There was a problem hiding this comment.
This was the best way I could think of to test equivalence, especially if we ever add new platforms. @jacobshandling would love your input on the naming of this equivalence checker.
2 tasks
jacobshandling
approved these changes
Mar 22, 2024
| @@ -638,12 +638,32 @@ const EditQueryForm = ({ | |||
| "differential_ignore_removals", | |||
| ].includes(lastEditedQueryLoggingType); | |||
|
|
|||
| // Note: The backend is not resetting the query reports with equivalent platform strings | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
FE of #17018
Description
Recording
https://www.loom.com/share/698e75a3d70f460799ed3c7458906cdc?sid=2133e4ae-04de-47ac-ad7c-77e78dbf5e06
Checklist for submitter
If some of the following don't apply, delete the relevant line.