Fleet UI: Users can see a tooltip on a disabled checkbox #17664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17664 +/- ##
==========================================
- Coverage 65.67% 65.67% -0.01%
==========================================
Files 1193 1193
Lines 108031 108027 -4
Branches 2574 2569 -5
==========================================
- Hits 70947 70943 -4
Misses 31713 31713
Partials 5371 5371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RachelElysia
force-pushed
the
label-disabled-tooltip
branch
from
d32134e to
986441f
Compare
jacobshandling
requested changes
Mar 22, 2024
RachelElysia
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
RachelElysia
force-pushed
the
label-disabled-tooltip
branch
from
270d359 to
a5cd847
Compare
RachelElysia
force-pushed
the
label-disabled-tooltip
branch
from
0cd6bbf to
55efd9e
Compare
Ended up using a mixin so I can keep the disabled state on hover as well |
jacobshandling
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Cerra #16345
Description
Screenrecording
https://www.loom.com/share/1abb1219ead7454c8d61b219887e2d20?sid=30e9acfb-bfe7-4458-97f9-40dedf9266e6
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/ororbit/changes/.