Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Persist toast messages after a modal closes #17674

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

RachelElysia
Copy link
Member

Issue

Cerra #17624

Description

  • Persist flash message even when a modal closes

Note: I don't know why this recently broke, maybe the update to React, but the hide flash shouldn't have been in the onExit a modal call anywho.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/ or orbit/changes/.
  • Manual QA for all new/changed functionality

@RachelElysia RachelElysia requested a review from a team as a code owner March 15, 2024 18:42
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.68%. Comparing base (57d00f3) to head (9ca3fef).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17674      +/-   ##
==========================================
- Coverage   65.68%   65.68%   -0.01%     
==========================================
  Files        1193     1193              
  Lines      108028   108026       -2     
  Branches     2574     2574              
==========================================
- Hits        70961    70959       -2     
  Misses      31701    31701              
  Partials     5366     5366              
Flag Coverage Δ
frontend 51.94% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RachelElysia RachelElysia merged commit b9c3d3a into main Mar 18, 2024
14 checks passed
@RachelElysia RachelElysia deleted the toast-messages branch March 18, 2024 18:53
@RachelElysia RachelElysia restored the toast-messages branch March 20, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants