Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Clickable elements include cursor hover state #17688

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Mar 18, 2024

Issue

Cerra #17208

Description

  • Find all clickable elements in UI that do not have a hover state and add hoverstate
    • Checkbox hoverstates added: unchecked has outline, checked/indeterminate gets darker, cursor becomes pointer
    • Rows that are clickable should have pointer cursor
    • Dropdowns that are clickable should have pointer cursor

Screenrecording of fixes

https://www.loom.com/share/00e3309b15ab4f7887c5741cbdeaf3ba?sid=610fe6c9-2a4c-4ac0-b2e2-682f47a94786

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/ or orbit/changes/.
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.68%. Comparing base (29e66ef) to head (033de97).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17688   +/-   ##
=======================================
  Coverage   65.68%   65.68%           
=======================================
  Files        1193     1193           
  Lines      108028   108028           
  Branches     2574     2574           
=======================================
  Hits        70961    70961           
  Misses      31701    31701           
  Partials     5366     5366           
Flag Coverage Δ
frontend 51.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RachelElysia RachelElysia marked this pull request as ready for review March 18, 2024 16:34
@RachelElysia RachelElysia requested a review from a team as a code owner March 18, 2024 16:34
@RachelElysia RachelElysia merged commit d5df239 into main Mar 22, 2024
14 checks passed
@RachelElysia RachelElysia deleted the dropdown-hover-state branch March 22, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants