Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update UI to add support for mac ddm profiles #17730

Merged
merged 9 commits into from
Mar 25, 2024

Conversation

ghernandez345
Copy link
Contributor

relates to #17416

update UI to support new DDM profile types. this includes:

  • updating Custom settings page

  • updating the os settings modal

  • Changes file added for user-visible changes in changes/ or orbit/changes/.
    See Changes files for more information.

  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 38.88889% with 11 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (feat-macos-ddm@577d5c2). Click here to learn what that means.

Files Patch % Lines
...ngsModal/OSSettingsTable/OSSettingsTableConfig.tsx 25.00% 6 Missing ⚠️
...dal/OSSettingsTable/OSSettingStatusCell/helpers.ts 50.00% 4 Missing ⚠️
frontend/services/entities/mdm.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             feat-macos-ddm   #17730   +/-   ##
=================================================
  Coverage                  ?   65.64%           
=================================================
  Files                     ?     1194           
  Lines                     ?   108285           
  Branches                  ?     2574           
=================================================
  Hits                      ?    71087           
  Misses                    ?    31793           
  Partials                  ?     5405           
Flag Coverage Δ
frontend 51.95% <38.88%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghernandez345 ghernandez345 changed the title Feat UI ddm profiles update UI to add support for mac ddm profiles Mar 20, 2024
@ghernandez345 ghernandez345 marked this pull request as ready for review March 21, 2024 16:51
@ghernandez345 ghernandez345 requested a review from a team as a code owner March 21, 2024 16:51
@ghernandez345 ghernandez345 self-assigned this Mar 21, 2024
@ghernandez345 ghernandez345 merged commit d3c8438 into feat-macos-ddm Mar 25, 2024
11 checks passed
@ghernandez345 ghernandez345 deleted the feat-ui-ddm-profiles branch March 25, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants