fix: prevent creating teams with reserved team names #21727
Conversation
|
Note: based on this code the requirement in the bug ticket for something like |
ee/server/service/teams.go
Outdated
| return nil, fleet.NewInvalidArgumentError("name", "may not be all teams") | ||
| } | ||
| if l == strings.ToLower(fleet.ReservedNameNoTeam) { | ||
| return nil, fleet.NewInvalidArgumentError("name", "may not be no team") |
There was a problem hiding this comment.
dumb question, why these have a different error message? the two below look better:
"All teams" is a reserved team name`
There was a problem hiding this comment.
@roperzh I think I was just trying to be consistent with the other errors in this part of the code. I can update it to be consistent with the other errors I added though.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21727 +/- ##
==========================================
- Coverage 64.84% 64.84% -0.01%
==========================================
Files 1500 1500
Lines 119108 119123 +15
Branches 3502 3509 +7
==========================================
+ Hits 77240 77249 +9
- Misses 34858 34861 +3
- Partials 7010 7013 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I was thinking about this as well! What would we rename them to? |
|
I thought it was informally discussed we won't try to migrate old teams bye I might be misremembering |
|
Yeah, it makes sense it would break some workflows (e.g. gitops). |
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.