Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI – Host details updates for Uninstall packages #21898

Conversation

jacobshandling
Copy link
Contributor

@jacobshandling jacobshandling commented Sep 7, 2024

#21566

  • Implement updates for uninstalling packages on the host details > software page. Full tasks outlined in the issue, Figma here

Updated install status tooltips:
install-status-tooltips

Uninstall action:
uninstall-action

Update install details:
Screenshot 2024-09-09 at 1 12 58 PM

  • Manual QA for all new/changed functionality: to do once backend finished

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 8.19672% with 56 lines in your changes missing coverage. Please review.

Project coverage is 55.63%. Comparing base (026f133) to head (2873289).
Report is 17 commits behind head on 20320-feat-uninstall-packages.

Files with missing lines Patch % Lines
...details/cards/Software/HostSoftwareTableConfig.tsx 0.00% 28 Missing ⚠️
...ages/hosts/details/cards/Software/HostSoftware.tsx 0.00% 16 Missing ⚠️
.../SoftwareInstallDetails/SoftwareInstallDetails.tsx 0.00% 5 Missing ⚠️
frontend/services/entities/hosts.ts 0.00% 3 Missing ⚠️
...re/SelfService/SelfServiceItem/SelfServiceItem.tsx 60.00% 2 Missing ⚠️
frontend/utilities/endpoints.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           20320-feat-uninstall-packages   #21898      +/-   ##
=================================================================
- Coverage                          55.64%   55.63%   -0.02%     
=================================================================
  Files                               1501     1501              
  Lines                             119006   119028      +22     
  Branches                            3453     3462       +9     
=================================================================
- Hits                               66218    66216       -2     
- Misses                             46601    46625      +24     
  Partials                            6187     6187              
Flag Coverage Δ
frontend 52.21% <8.19%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobshandling jacobshandling changed the title 21566 uninstall host details UI UI – Host details updates for Uninstall packages Sep 7, 2024
@jacobshandling jacobshandling marked this pull request as ready for review September 9, 2024 20:18
@jacobshandling jacobshandling requested a review from a team as a code owner September 9, 2024 20:18
@jacobshandling
Copy link
Contributor Author

Closing in favor of #21933, per updated branching strategy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants