Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for codesign table on osquery-perf #23855

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

lucasmrod
Copy link
Member

@lucasmrod lucasmrod commented Nov 15, 2024

I missed to add support for load testing in: #23766.

for #23858

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 63.17%. Comparing base (fa1a714) to head (8e4855c).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
cmd/osquery-perf/agent.go 0.00% 39 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23855      +/-   ##
==========================================
+ Coverage   63.14%   63.17%   +0.03%     
==========================================
  Files        1559     1560       +1     
  Lines      148163   148399     +236     
  Branches     3722     3722              
==========================================
+ Hits        93553    93757     +204     
- Misses      47209    47243      +34     
+ Partials     7401     7399       -2     
Flag Coverage Δ
backend 64.02% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a few reads to understand what's going on, but this makes sense.

@lucasmrod lucasmrod merged commit 351fb36 into main Nov 15, 2024
21 checks passed
@lucasmrod lucasmrod deleted the 8750-osquery-perf-load-testing-changes branch November 15, 2024 19:30
@lukeheath lukeheath modified the milestone: 4.59.1 Nov 15, 2024
lucasmrod added a commit that referenced this pull request Nov 15, 2024
I missed to add support for load testing in:
#23766.
lukeheath pushed a commit that referenced this pull request Nov 15, 2024
I missed to add support for load testing in:
#23766.
lucasmrod added a commit that referenced this pull request Nov 15, 2024
I missed to add support for load testing in:
#23766.
iansltx pushed a commit that referenced this pull request Nov 15, 2024
Cherry pick PR #23855 into RC v4.60.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants