-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux key escrow progress windows #24069
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostlikelee
had a problem deploying
to
Docker Hub
November 22, 2024 12:56 — with
GitHub Actions
Error
mostlikelee
temporarily deployed
to
Docker Hub
November 22, 2024 13:04 — with
GitHub Actions
Inactive
mostlikelee
force-pushed
the
24013-luks-progress-windows
branch
from
November 22, 2024 18:08
bdedaf9
to
899b371
Compare
mostlikelee
had a problem deploying
to
Docker Hub
November 22, 2024 18:08 — with
GitHub Actions
Failure
mostlikelee
temporarily deployed
to
Docker Hub
November 22, 2024 19:09 — with
GitHub Actions
Inactive
lucasmrod
reviewed
Nov 22, 2024
lucasmrod
reviewed
Nov 22, 2024
lucasmrod
approved these changes
Nov 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24069 +/- ##
==========================================
- Coverage 63.40% 63.39% -0.02%
==========================================
Files 1579 1579
Lines 150006 150038 +32
Branches 3818 3818
==========================================
+ Hits 95112 95114 +2
- Misses 47309 47338 +29
- Partials 7585 7586 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
mostlikelee
added a commit
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24013
Adding progress windows to key escrow process during passphrase validation and key escrow. Because of how we launch user processes as root (
execuser.Run
), to kill a progress window (runs until killed) we cannot simply cancel the context orcmd.Process.Kill()
. This PR takes a brute force approach by killing allzenity
processes. Also attempted limiting the kill scope by only killing child processes of orbit, but thezenity
user process does not show up as a child process after launched.ps aux
shows 2 zenity processes: 1 as sudo, the other as a zenity process in user space.Also included are some bug and copy fixes to the user prompts.
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.See Changes files for more information.
runtime.GOOS
).