Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux key escrow progress windows #24069

Merged
merged 7 commits into from
Nov 22, 2024
Merged

Conversation

mostlikelee
Copy link
Contributor

@mostlikelee mostlikelee commented Nov 22, 2024

#24013

Adding progress windows to key escrow process during passphrase validation and key escrow. Because of how we launch user processes as root (execuser.Run), to kill a progress window (runs until killed) we cannot simply cancel the context or cmd.Process.Kill(). This PR takes a brute force approach by killing all zenity processes. Also attempted limiting the kill scope by only killing child processes of orbit, but the zenity user process does not show up as a child process after launched. ps aux shows 2 zenity processes: 1 as sudo, the other as a zenity process in user space.

Also included are some bug and copy fixes to the user prompts.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated tests
  • Manual QA for all new/changed functionality
  • For Orbit and Fleet Desktop changes:
    • Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (runtime.GOOS).
    • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
    • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

@mostlikelee mostlikelee merged commit 7b932e8 into main Nov 22, 2024
30 checks passed
@mostlikelee mostlikelee deleted the 24013-luks-progress-windows branch November 22, 2024 19:30
mostlikelee added a commit that referenced this pull request Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 11.59420% with 61 lines in your changes missing coverage. Please review.

Project coverage is 63.39%. Comparing base (a8ba004) to head (c6267a9).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
orbit/pkg/luks/luks_linux.go 0.00% 46 Missing ⚠️
orbit/pkg/zenity/zenity.go 42.10% 11 Missing ⚠️
orbit/pkg/execuser/execuser_linux.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24069      +/-   ##
==========================================
- Coverage   63.40%   63.39%   -0.02%     
==========================================
  Files        1579     1579              
  Lines      150006   150038      +32     
  Branches     3818     3818              
==========================================
+ Hits        95112    95114       +2     
- Misses      47309    47338      +29     
- Partials     7585     7586       +1     
Flag Coverage Δ
backend 64.25% <11.59%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

mostlikelee added a commit that referenced this pull request Nov 22, 2024
mostlikelee added a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants