Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support old cryptsetup #24426

Merged
merged 2 commits into from
Dec 5, 2024
Merged

support old cryptsetup #24426

merged 2 commits into from
Dec 5, 2024

Conversation

mostlikelee
Copy link
Contributor

@mostlikelee mostlikelee commented Dec 5, 2024

#24215

<2.4 versions of cryptsetup don't support the same json flag and only support a json debug dump which requires extracting the json from a text blob.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated tests
  • Manual QA for all new/changed functionality
  • For Orbit and Fleet Desktop changes:
    • Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (runtime.GOOS).
    • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
    • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

@mostlikelee mostlikelee marked this pull request as ready for review December 5, 2024 17:59
@mostlikelee mostlikelee requested a review from a team as a code owner December 5, 2024 17:59
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 17.39130% with 38 lines in your changes missing coverage. Please review.

Project coverage is 63.43%. Comparing base (476ffcb) to head (46fec98).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
orbit/pkg/luks/luks_linux.go 0.00% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24426      +/-   ##
==========================================
- Coverage   63.46%   63.43%   -0.04%     
==========================================
  Files        1586     1589       +3     
  Lines      150449   150990     +541     
  Branches     3867     3867              
==========================================
+ Hits        95484    95775     +291     
- Misses      47345    47571     +226     
- Partials     7620     7644      +24     
Flag Coverage Δ
backend 64.30% <17.39%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mostlikelee mostlikelee merged commit 7985261 into main Dec 5, 2024
36 checks passed
@mostlikelee mostlikelee deleted the 24215-keyslot2 branch December 5, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants