Add missing CIS checks #24787
Merged
Add missing CIS checks #24787
+45
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defensivedepth
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
sharon-fdm
reviewed
Jan 7, 2025
| AND line LIKE '%!log_allowed%' | ||
| ) | ||
| -- OR line exists but is commented | ||
| OR EXISTS ( |
There was a problem hiding this comment.
Shouldn't this be:
AND NOT EXISTS
?
sharon-fdm
reviewed
Jan 8, 2025
fleet-release
approved these changes
Jan 8, 2025
sharon-fdm
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Code looks good to me.
Tests:
- Ensure Logging Is Enabled for Sudo - tested on @defensivedepth's machine.
- Verify that Improve Assistive Voice Features is not enabled - Tested on Sharon's machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #24647
Adds:
2.6.3.1, 2.6.3.2, 2.6.3.4 were previously added.
2.7.2. is a
Manualcheck, which is not supported here.