Skip to content

MSP dashboard: exclude Fleet maintained apps from software page #24966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

eashaw
Copy link
Contributor

@eashaw eashaw commented Dec 20, 2024

Related to: #24918

Changes:

  • Updated get-software and view-software to exclude Fleet maintained apps.

@lukeheath
Copy link
Member

@eashaw Does this need review before being approved? Or can it be approved now?

@eashaw
Copy link
Contributor Author

eashaw commented Jan 10, 2025

@lukeheath I was going to accept the auto-approval by the GH bot and merge this PR once it has gone through QA. Should I request another reviewer for this?

@lukeheath
Copy link
Member

lukeheath commented Jan 13, 2025

@eashaw Got it. For any PR that isn't "ready to merge" once it's reviewed/approved, let's keep it in draft status. Thanks!

@lukeheath lukeheath marked this pull request as draft January 13, 2025 21:51
@eashaw
Copy link
Contributor Author

eashaw commented Jan 16, 2025

The change in this PR does not resolve the issue. I'm closing this PR and will open a new one to resolve this issue once Fleet maintained apps can be excluded from API responses.

@eashaw eashaw closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants