-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Apple config/DDM profiles if secret variables changed #24995
Update Apple config/DDM profiles if secret variables changed #24995
Conversation
af50427
to
5a115f5
Compare
6643a8e
to
91ff746
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24995 +/- ##
=======================================
Coverage 63.82% 63.83%
=======================================
Files 1613 1614 +1
Lines 153431 153516 +85
Branches 3985 4036 +51
=======================================
+ Hits 97922 97991 +69
- Misses 47716 47727 +11
- Partials 7793 7798 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…figuration_profiles endpoint.
979806b
to
e944daa
Compare
…rofiles-on-secret-change # Conflicts: # server/service/apple_mdm.go # server/service/integration_mdm_profiles_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable. This is code I haven't touched before so my signoff is caveated with "this needs an airtight QA plan" but the new functionality and tweaks to existing (e.g. pushing checksums to the DB) make sense.
#24900
This PR includes and depends on PR #25012, which should be reviewed/merged before this one.
Windows profiles are not included in this PR due to issue #25030
This PR adds the following functionality: Apple config/DDM profile is resent to the device when the profile contains secret variables, and the values of those variables have changed. For example.
Checklist for submitter
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.See Changes files for more information.