-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug where DDM/Windows profiles with secrets were not being marked Verified. #25065
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25065 +/- ##
==========================================
- Coverage 63.84% 63.82% -0.02%
==========================================
Files 1614 1615 +1
Lines 153580 153595 +15
Branches 4040 4040
==========================================
- Hits 98048 98034 -14
- Misses 47736 47757 +21
- Partials 7796 7804 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I understand what's going on here (basically removing checksum when it's not relevant and relying on token instead, and updating uploaded_at
when secrets change, which I was thinking in the direction of when I reviewed the last secrets PR), so will let this get merged so it lands ahead of the RC cut. Would be helpful to include a description of why this fix works in the squash merge commit notes though.
Yes, this fix has a bit more code than just the fix. The problem for DDM profiles was that host_mdm_apple_delcarations.checksum was being used for verification, while host was returning the token (which contained the secrets timestamp). I wanted to remove the checksum initially, but I kept it for backwards compatibility. With this issue, I thought it was cleaner to just have token and no checksum. I made a note in the secrets guide that DDM "checksum" will now be an MD5 hash of JSON + secrets timestamp (if present). |
Fixing unreleased secret variables bug where DDM and Windows profiles were not transitioning to Verified.
#23238
Checklist for submitter