Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore UI more fixes scoped software label #25118

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

ghernandez345
Copy link
Contributor

relates to #25067, #25061

includes two fixes for the scoped software via labels feature:

  1. update the delete label modal copy
  2. don't show the confirm changes modal if only the self service value has changed.
  • Manual QA for all new/changed functionality

@ghernandez345 ghernandez345 requested a review from a team as a code owner January 3, 2025 11:29
@ghernandez345 ghernandez345 self-assigned this Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.82%. Comparing base (40da87a) to head (9484d5c).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
frontend/pages/hosts/ManageHostsPage/helpers.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25118      +/-   ##
==========================================
- Coverage   63.82%   63.82%   -0.01%     
==========================================
  Files        1615     1615              
  Lines      153604   153602       -2     
  Branches     3951     3949       -2     
==========================================
- Hits        98045    98043       -2     
  Misses      47757    47757              
  Partials     7802     7802              
Flag Coverage Δ
frontend 53.27% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jacobshandling jacobshandling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ghernandez345 ghernandez345 merged commit 69cef7c into main Jan 3, 2025
14 checks passed
@ghernandez345 ghernandez345 deleted the chore-ui-more-fixes-scoped-software-label branch January 3, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants