Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add software_title_id to added_app_store_app activity #25119

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

ghernandez345
Copy link
Contributor

@ghernandez345 ghernandez345 commented Jan 3, 2025

relates to #24120

adds the software_title_id to the added_app_store_activity

  • Added/updated automated tests
  • Manual QA for all new/changed functionality

@ghernandez345 ghernandez345 force-pushed the feat-add-software-title-id-to-activities branch from 5482c2c to 141e439 Compare January 3, 2025 14:17
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.83%. Comparing base (40da87a) to head (a96b384).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
ee/server/service/vpp.go 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25119   +/-   ##
=======================================
  Coverage   63.82%   63.83%           
=======================================
  Files        1615     1615           
  Lines      153604   153607    +3     
  Branches     3951     3951           
=======================================
+ Hits        98045    98055   +10     
+ Misses      47757    47751    -6     
+ Partials     7802     7801    -1     
Flag Coverage Δ
backend 64.70% <90.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jahzielv jahzielv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ghernandez345 ghernandez345 merged commit b193f2d into main Jan 3, 2025
27 checks passed
@ghernandez345 ghernandez345 deleted the feat-add-software-title-id-to-activities branch January 3, 2025 16:03
ghernandez345 added a commit that referenced this pull request Jan 3, 2025
relates to #24120

adds the `software_title_id` to the `added_app_store_activity`

- [x] Added/updated automated tests
- [x] Manual QA for all new/changed functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants