Refactoring crypto code for future reuse.#25148
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25148 +/- ##
==========================================
+ Coverage 54.30% 63.83% +9.52%
==========================================
Files 1615 1615
Lines 153594 153607 +13
Branches 3987 3987
==========================================
+ Hits 83416 98052 +14636
+ Misses 63296 47753 -15543
- Partials 6882 7802 +920
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mna
approved these changes
Jan 7, 2025
|
|
||
| // GenerateSubjectKeyID generates Subject Key Identifier (SKI) using SHA-256 | ||
| // hash of the public key bytes according to RFC 7093 section 2. | ||
| func GenerateSubjectKeyID(pub crypto.PublicKey) ([]byte, error) { |
Member
There was a problem hiding this comment.
Haven't fully reviewed, I assume this (and related tests) were just code copied from the old places?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring crypto code for future reuse for #24869. No functional changes.