Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI – Clarify expected behavior of policy host counts, dashboard controls software count, and controls os updates versions count #25150

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

jacobshandling
Copy link
Contributor

For #23512

Screenshot 2025-01-03 at 4 13 33 PM Screenshot 2025-01-03 at 3 59 56 PM Screenshot 2025-01-03 at 4 14 40 PM
  • Changes file added for user-visible changes in changes/
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.82%. Comparing base (338a00a) to head (21c36da).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25150      +/-   ##
==========================================
- Coverage   63.82%   63.82%   -0.01%     
==========================================
  Files        1615     1615              
  Lines      153598   153587      -11     
  Branches     3986     4032      +46     
==========================================
- Hits        98038    98029       -9     
+ Misses      47759    47757       -2     
  Partials     7801     7801              
Flag Coverage Δ
frontend 53.24% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sgress454 sgress454 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, a couple nitpicky questions about style.

Also, not addressed in this PR but as we're addressing ambiguity, "updated never" seems like a less than ideal phrase to use when we don't have an update yet:

image

Might be worth tweaking the <LastUpdatedText> logic so that if the time is "never" we say something like "no updates yet" instead.

Comment on lines +299 to +301
.component__last-updated-text {
font-weight: normal;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why normal here and bold everywhere else? e.g.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated globally here after confirming with @eugkuo https://github.com/fleetdm/fleet/pull/25143/files#r1904469843

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eugkuo 's comment to be consistent and unbold everywhere: #25143 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, @jacobshandling in that case let's remove this carve-out so that it uses the global style

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RachelElysia I'm going to merge this in since it's approved – since your PR is still waiting for review, can you please remove this one-off style in favor of the global update in your PR?

@jacobshandling
Copy link
Contributor Author

jacobshandling commented Jan 6, 2025

Might be worth tweaking the logic so that if the time is "never" we say something like "no updates yet" instead.

@sgress454 good idea, worth adding to design review for product consideration I'd say (added for us 👍)

@jacobshandling jacobshandling merged commit aef4bb5 into main Jan 6, 2025
14 checks passed
@jacobshandling jacobshandling deleted the 23512 branch January 6, 2025 18:55
@rachaelshaw
Copy link
Member

Might be worth tweaking the logic so that if the time is "never" we say something like "no updates yet" instead.

@sgress454 good idea, worth adding to design review for product consideration I'd say (added for us 👍)

Brought this up @ design review; decided it makes the most sense to just hide the "Updated…" text if it's never been updated. I'll make an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants