-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI – Clarify expected behavior of policy host counts, dashboard controls software count, and controls os updates versions count #25150
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25150 +/- ##
==========================================
- Coverage 63.82% 63.82% -0.01%
==========================================
Files 1615 1615
Lines 153598 153587 -11
Branches 3986 4032 +46
==========================================
- Hits 98038 98029 -9
+ Misses 47759 47757 -2
Partials 7801 7801
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, a couple nitpicky questions about style.
Also, not addressed in this PR but as we're addressing ambiguity, "updated never" seems like a less than ideal phrase to use when we don't have an update yet:
Might be worth tweaking the <LastUpdatedText>
logic so that if the time is "never" we say something like "no updates yet" instead.
...ages/ManageControlsPage/OSUpdates/components/CurrentVersionSection/CurrentVersionSection.tsx
Show resolved
Hide resolved
.component__last-updated-text { | ||
font-weight: normal; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated globally here after confirming with @eugkuo https://github.com/fleetdm/fleet/pull/25143/files#r1904469843
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eugkuo 's comment to be consistent and unbold everywhere: #25143 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, @jacobshandling in that case let's remove this carve-out so that it uses the global style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RachelElysia I'm going to merge this in since it's approved – since your PR is still waiting for review, can you please remove this one-off style in favor of the global update in your PR?
@sgress454 good idea, worth adding to design review for product consideration I'd say (added for us 👍) |
Brought this up @ design review; decided it makes the most sense to just hide the "Updated…" text if it's never been updated. I'll make an issue. |
For #23512
changes/