Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for command line installation on pkg gen #25166

Merged
merged 7 commits into from
Jan 6, 2025

Conversation

dantecatalfamo
Copy link
Member

@dantecatalfamo dantecatalfamo commented Jan 6, 2025

#25004

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 63.83%. Comparing base (efe3315) to head (3a42af9).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
cmd/fleetctl/package.go 50.00% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #25166    +/-   ##
========================================
  Coverage   63.83%   63.83%            
========================================
  Files        1615     1615            
  Lines      153602   153712   +110     
  Branches     3986     3986            
========================================
+ Hits        98046    98128    +82     
- Misses      47754    47775    +21     
- Partials     7802     7809     +7     
Flag Coverage Δ
backend 64.71% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantecatalfamo dantecatalfamo marked this pull request as ready for review January 6, 2025 17:19
@dantecatalfamo dantecatalfamo requested a review from a team as a code owner January 6, 2025 17:19
cmd/fleetctl/package.go Outdated Show resolved Hide resolved
@dantecatalfamo dantecatalfamo merged commit d48c9ba into main Jan 6, 2025
27 checks passed
@dantecatalfamo dantecatalfamo deleted the command-line-installer-instructions branch January 6, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants