Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Fleet maintained app 404 sends to 404 page #25167

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

RachelElysia
Copy link
Member

Issue

For #24638

Description

  • Fleet maintained app 404 sends to 404 page
  • Remove 3 retries to match other pages that send to 404 immediately after first try (e.g. host details page 404)

If some of the following don't apply, delete the relevant line.

  • Manual QA for all new/changed functionality

@RachelElysia RachelElysia requested a review from a team as a code owner January 6, 2025 16:13
@RachelElysia RachelElysia merged commit 91f4c64 into main Jan 6, 2025
8 checks passed
@RachelElysia RachelElysia deleted the 24638-fma-404 branch January 6, 2025 16:26
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.83%. Comparing base (efe3315) to head (bf5d10d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25167   +/-   ##
=======================================
  Coverage   63.83%   63.83%           
=======================================
  Files        1615     1615           
  Lines      153602   153602           
  Branches     3986     3986           
=======================================
  Hits        98046    98046           
  Misses      47754    47754           
  Partials     7802     7802           
Flag Coverage Δ
frontend 53.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants