Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retrigger automatic installations after label scope changes (#25163) #25172

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

jahzielv
Copy link
Contributor

@jahzielv jahzielv commented Jan 6, 2025

cherry-pick of #25163 for #25071

)

> Related issue: #25071

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [x] Added/updated automated tests
- [x] A detailed QA plan exists on the associated ticket (if it isn't
there, work with the product group's QA engineer to add it)
- [x] Manual QA for all new/changed functionality
@jahzielv jahzielv requested a review from a team as a code owner January 6, 2025 17:20
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 76.40449% with 21 lines in your changes missing coverage. Please review.

Please upload report for BASE (rc-minor-fleet-v4.62.0@cf566f7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
ee/server/service/software_installers.go 59.09% 6 Missing and 3 partials ⚠️
server/datastore/mysql/policies.go 73.91% 4 Missing and 2 partials ⚠️
server/datastore/mysql/software_installers.go 83.33% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.62.0   #25172   +/-   ##
=========================================================
  Coverage                          ?   63.84%           
=========================================================
  Files                             ?     1615           
  Lines                             ?   153694           
  Branches                          ?     3986           
=========================================================
  Hits                              ?    98126           
  Misses                            ?    47761           
  Partials                          ?     7807           
Flag Coverage Δ
backend 64.71% <76.40%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jahzielv jahzielv merged commit f2ff46b into rc-minor-fleet-v4.62.0 Jan 6, 2025
22 checks passed
@jahzielv jahzielv deleted the 25071-cherry-pick branch January 6, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants