Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API, datastore, migration for new "user settings", with `"hidden_hosts_table_columns" setting #25184

Merged
merged 25 commits into from
Jan 9, 2025

Conversation

jacobshandling
Copy link
Contributor

@jacobshandling jacobshandling commented Jan 6, 2025

For #25033

  • For database migrations:
    • Checked schema for all modified table for columns that will auto-update timestamps during migration.
    • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 56.16438% with 32 lines in your changes missing coverage. Please review.

Project coverage is 63.85%. Comparing base (cac3e2f) to head (8a4ec25).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
server/datastore/mysql/users.go 54.83% 10 Missing and 4 partials ⚠️
server/service/users.go 60.86% 6 Missing and 3 partials ⚠️
...es/20250107165731_AddSettingsColumnToUsersTable.go 50.00% 4 Missing and 1 partial ⚠️
server/fleet/users.go 50.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25184   +/-   ##
=======================================
  Coverage   63.85%   63.85%           
=======================================
  Files        1616     1617    +1     
  Lines      153833   153913   +80     
  Branches     3939     3939           
=======================================
+ Hits        98231    98283   +52     
- Misses      47789    47809   +20     
- Partials     7813     7821    +8     
Flag Coverage Δ
backend 64.72% <56.16%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass looks good to me.

@jacobshandling jacobshandling marked this pull request as ready for review January 8, 2025 01:20
@jacobshandling jacobshandling requested a review from a team as a code owner January 8, 2025 01:20
Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left some comments.

lucasmrod
lucasmrod previously approved these changes Jan 8, 2025
@jacobshandling jacobshandling merged commit 55b500a into main Jan 9, 2025
25 checks passed
@jacobshandling jacobshandling deleted the 25033-user-settings-backend branch January 9, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants