-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API, datastore, migration for new "user settings", with `"hidden_hosts_table_columns" setting #25184
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25184 +/- ##
=======================================
Coverage 63.85% 63.85%
=======================================
Files 1616 1617 +1
Lines 153833 153913 +80
Branches 3939 3939
=======================================
+ Hits 98231 98283 +52
- Misses 47789 47809 +20
- Partials 7813 7821 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
server/datastore/mysql/migrations/tables/20250103112935_AddSettingsColumnToUsersTable_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass looks good to me.
- todo - migration test
…these migrations)
d4d65e7
to
a41be09
Compare
9e13c22
to
b842a87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left some comments.
For #25033