Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Add copy for policy tied to install software #25242

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Jan 8, 2025

Issue

For #25245 (Addition to #22813)

Description

  • Adds help text sentence to policy that has install_software key
  • Links to software details page, tooltip
  • Shorten other help text according to Figma
  • Change Targets to Target

Note

API doesn't return extension like shown in figma design so UI does not show extension on the software name
Screenshot 2025-01-08 at 10 03 51 AM

Screenshot

Screenshot 2025-01-08 at 10 45 33 AM

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Manual QA for all new/changed functionality

iansltx
iansltx previously approved these changes Jan 8, 2025
Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically we only show the --- for failed policies (/cc @noahtalerman), so if the software got installed on the host some other way the policy will show as passing, but as long as we're aware of that nuance internally proceeding with this copy seems fine.

Thanks for the quick turn on this change!

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.85%. Comparing base (e956220) to head (f5c4d5b).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...d/components/PlatformSelector/PlatformSelector.tsx 85.71% 1 Missing ⚠️
frontend/hooks/usePlatformSelector.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25242   +/-   ##
=======================================
  Coverage   63.85%   63.85%           
=======================================
  Files        1616     1616           
  Lines      153833   153840    +7     
  Branches     3975     4027   +52     
=======================================
+ Hits        98224    98232    +8     
+ Misses      47796    47795    -1     
  Partials     7813     7813           
Flag Coverage Δ
frontend 53.26% <75.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RachelElysia RachelElysia merged commit 3c634df into main Jan 8, 2025
14 checks passed
@RachelElysia RachelElysia deleted the 22813-unreleased-install-software-copy branch January 8, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants