Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Fix software name from overflowing #25262

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

RachelElysia
Copy link
Member

Issue

For #25072

Description

  • Long software names can overflow their containers, fix to wrap on upload progress and delete software modal

Screenshot

Screenshot 2025-01-08 at 2 27 09 PM Screenshot 2025-01-08 at 2 19 31 PM

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • Manual QA for all new/changed functionality

@RachelElysia RachelElysia requested a review from a team as a code owner January 8, 2025 19:39
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.85%. Comparing base (c0d63e9) to head (6fdd320).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25262   +/-   ##
=======================================
  Coverage   63.85%   63.85%           
=======================================
  Files        1616     1616           
  Lines      153836   153836           
  Branches     3976     3976           
=======================================
  Hits        98230    98230           
  Misses      47792    47792           
  Partials     7814     7814           
Flag Coverage Δ
frontend 53.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l o n g b o i

@RachelElysia RachelElysia merged commit 800aa7e into main Jan 8, 2025
11 checks passed
@RachelElysia RachelElysia deleted the 25072-software-name-overflow branch January 8, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants