Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgraded expected/common "BootstrapPackage not found" server error to a debug message. #25266

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

getvictor
Copy link
Member

For #25265
Downgraded expected/common "BootstrapPackage not found" server error to a debug message. Occurs when UI/API checks if bootstrap package exists.

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • Manual QA for all new/changed functionality

@getvictor getvictor marked this pull request as ready for review January 8, 2025 21:29
@getvictor getvictor requested a review from a team as a code owner January 8, 2025 21:29
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.85%. Comparing base (f7ac65d) to head (eafff54).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
ee/server/service/software_installers.go 0.00% 2 Missing ⚠️
server/service/apple_mdm.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25266   +/-   ##
=======================================
  Coverage   63.85%   63.85%           
=======================================
  Files        1616     1616           
  Lines      153829   153844   +15     
  Branches     3990     3990           
=======================================
+ Hits        98222    98237   +15     
- Misses      47793    47794    +1     
+ Partials     7814     7813    -1     
Flag Coverage Δ
backend 64.72% <84.21%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@getvictor getvictor merged commit 992144b into main Jan 8, 2025
25 checks passed
@getvictor getvictor deleted the victor/25265-bootstrap-package-not-found branch January 8, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants