Skip to content

Fleetd can now download software installers from signed CDN URLs.#25276

Merged
getvictor merged 16 commits intomainfrom
victor/24870-fleetd-download-from-CDN
Jan 29, 2025
Merged

Fleetd can now download software installers from signed CDN URLs.#25276
getvictor merged 16 commits intomainfrom
victor/24870-fleetd-download-from-CDN

Conversation

@getvictor
Copy link
Member

@getvictor getvictor commented Jan 8, 2025

For #24870 subtask

API changes doc: #25293

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added support on fleet's osquery simulator cmd/osquery-perf for new osquery data ingestion features.
  • Added/updated automated tests
  • Manual QA for all new/changed functionality
  • For Orbit and Fleet Desktop changes:
    • Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (runtime.GOOS).
    • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
    • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

@codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 6.50407% with 230 lines in your changes missing coverage. Please review.

Project coverage is 63.80%. Comparing base (dfa9a90) to head (ce2767a).
Report is 243 commits behind head on main.

Files with missing lines Patch % Lines
cmd/osquery-perf/osquery_perf/stats.go 0.00% 146 Missing ⚠️
server/service/orbit_client.go 0.00% 36 Missing ⚠️
...md/osquery-perf/installer_cache/installer-cache.go 0.00% 27 Missing ⚠️
server/service/base_client.go 0.00% 10 Missing ⚠️
cmd/osquery-perf/agent.go 0.00% 7 Missing ⚠️
orbit/pkg/installer/installer.go 81.25% 2 Missing and 1 partial ⚠️
server/service/orbit.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25276      +/-   ##
==========================================
- Coverage   63.81%   63.80%   -0.01%     
==========================================
  Files        1616     1617       +1     
  Lines      153891   154069     +178     
  Branches     3978     3974       -4     
==========================================
+ Hits        98205    98311     +106     
- Misses      47869    47933      +64     
- Partials     7817     7825       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@getvictor getvictor marked this pull request as ready for review January 9, 2025 18:00
@getvictor getvictor requested a review from a team as a code owner January 9, 2025 18:00
@lucasmrod
Copy link
Member

Friendly reminder orbit changes are on freeze.

@georgekarrv georgekarrv marked this pull request as draft January 14, 2025 17:44
@georgekarrv
Copy link
Member

Converted to draft to hold it over until it can merge after the orbit freeze

@getvictor getvictor marked this pull request as ready for review January 29, 2025 16:24
@getvictor getvictor merged commit 5c0dfbf into main Jan 29, 2025
@getvictor getvictor deleted the victor/24870-fleetd-download-from-CDN branch January 29, 2025 16:24
@PezHub PezHub mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants