Fix typo in Fleet server configuration. #25302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For #24195. The existing POST /scripts method uses a multipart request, and I figure that since we use multipart for both create and edit on installers, we want the same level of consistency on scripts. If we _don't_ want this, and want a JSON payload instead, we probably still want to rename `script_contents` to `script` for consistency with the field name in the create API.
- `GET /activities` API design for the following user story: - #24195
relates to #24247 There's nothing actually wrong in the current docs. We document that to set `script_execution_timeout` in a YAML file you do: ```yaml agent_options: script_execution_timeout: 600 ``` which is correct. It's just that in the UI we hide the top-level `agent_options` key entirely. This makes sense from a UX standpoint but it's easy to see how someone could get confused. The _best_ option would be to have `script_execution_timeout` always returned from the config endpoint so that it appeared in the right place in the UI and the user would just have to edit it, but I'd wait for more reports on this before committing that level of effort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #23823