Skip to content

Expose smtp and sso settings to team admins #25322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Expose smtp and sso settings to team admins #25322

merged 3 commits into from
Jan 10, 2025

Conversation

jacobshandling
Copy link
Contributor

@jacobshandling jacobshandling commented Jan 10, 2025

For #25320

  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

@jacobshandling jacobshandling changed the title Do expose smtp and sso settings to team admins Expose smtp and sso settings to team admins Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.54%. Comparing base (f7ec76f) to head (609b1a1).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25322   +/-   ##
=======================================
  Coverage   63.54%   63.54%           
=======================================
  Files        1618     1618           
  Lines      154433   154469   +36     
  Branches     4037     4037           
=======================================
+ Hits        98130    98163   +33     
- Misses      48564    48566    +2     
- Partials     7739     7740    +1     
Flag Coverage Δ
backend 64.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobshandling jacobshandling marked this pull request as ready for review January 10, 2025 19:19
@jacobshandling jacobshandling requested review from rachaelshaw and a team as code owners January 10, 2025 19:19
Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left two comments.

@jacobshandling jacobshandling merged commit d26afe3 into main Jan 10, 2025
31 checks passed
@jacobshandling jacobshandling deleted the 25320 branch January 10, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants