Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of bash as a script interpreter #25449

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Allow use of bash as a script interpreter #25449

wants to merge 6 commits into from

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Jan 15, 2025

For #24470.

Haven't tested E2E yet as this requires building a new fleetd (which can/should be released before the server changes get tagged...if the server gets released first a bash script execution will error out but won't have any ill effects otherwise) + testing with local TUF (and also means this needs to go in after fleetd is unfrozen).

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
    • Try running a bash script on this fleet agent. In particular check that it can echo "$BASH_VERSION"
  • Manual QA for all new/changed functionality
  • For Orbit and Fleet Desktop changes:
    • Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (runtime.GOOS).
    • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
    • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

The orbit upload-artifact action has been updated due to the old version getting deprecated:
https://github.com/fleetdm/fleet/actions/runs/12933328765/job/36071680332?pr=25449#step:1:24
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.61%. Comparing base (07416c2) to head (d5be7af).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25449      +/-   ##
==========================================
+ Coverage   63.59%   63.61%   +0.02%     
==========================================
  Files        1622     1624       +2     
  Lines      155023   155309     +286     
  Branches     4003     4054      +51     
==========================================
+ Hits        98580    98796     +216     
- Misses      48661    48716      +55     
- Partials     7782     7797      +15     
Flag Coverage Δ
backend 64.47% <100.00%> (+0.02%) ⬆️
frontend 53.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantecatalfamo dantecatalfamo marked this pull request as ready for review January 23, 2025 16:07
@dantecatalfamo dantecatalfamo requested review from a team as code owners January 23, 2025 16:07
@@ -0,0 +1 @@
* Added bash interpreter support for script execution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's duplicate this file on orbit/changes/

Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(Reminder to not merge until we cut orbit 1.38.0, hopefully today!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants