-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow use of bash as a script interpreter #25449
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25449 +/- ##
==========================================
+ Coverage 63.59% 63.61% +0.02%
==========================================
Files 1622 1624 +2
Lines 155023 155309 +286
Branches 4003 4054 +51
==========================================
+ Hits 98580 98796 +216
- Misses 48661 48716 +55
- Partials 7782 7797 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -0,0 +1 @@ | |||
* Added bash interpreter support for script execution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's duplicate this file on orbit/changes/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(Reminder to not merge until we cut orbit 1.38.0, hopefully today!)
For #24470.
Haven't tested E2E yet as this requires building a new fleetd (which can/should be released before the server changes get tagged...if the server gets released first a bash script execution will error out but won't have any ill effects otherwise) + testing with local TUF (and also means this needs to go in after fleetd is unfrozen).
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.See Changes files for more information.
echo "$BASH_VERSION"
runtime.GOOS
).The orbit
upload-artifact
action has been updated due to the old version getting deprecated:https://github.com/fleetdm/fleet/actions/runs/12933328765/job/36071680332?pr=25449#step:1:24
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/