Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upcoming activities for ABM-deleted hosts #25530

Merged
merged 9 commits into from
Jan 21, 2025

Conversation

dantecatalfamo
Copy link
Member

@dantecatalfamo dantecatalfamo commented Jan 16, 2025

#22353

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
    • Create ABM enrolled host
    • Enqueue scripts, and software installs while the host is offline
    • Delete host (host should re-appear in the list of hosts after ABM restoration
    • Check that upcoming activities is clear, nothing executes on host
  • Manual QA for all new/changed functionality

@dantecatalfamo dantecatalfamo changed the title Begin work to fix upcoming activities for ABM-deleted hosts Fix upcoming activities for ABM-deleted hosts Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.60%. Comparing base (5f2b339) to head (fedec4c).
Report is 52 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25530   +/-   ##
=======================================
  Coverage   63.59%   63.60%           
=======================================
  Files        1619     1620    +1     
  Lines      154980   155066   +86     
  Branches     3987     3987           
=======================================
+ Hits        98565    98635   +70     
- Misses      48646    48659   +13     
- Partials     7769     7772    +3     
Flag Coverage Δ
backend 64.45% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantecatalfamo dantecatalfamo marked this pull request as ready for review January 20, 2025 16:55
@dantecatalfamo dantecatalfamo requested a review from a team as a code owner January 20, 2025 16:55
Copy link
Contributor

@sgress454 sgress454 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and tests LGTM. Not sure if there's a good way to test this locally without actually wiping a device? I'm also not sure what else might fall under the umbrella of "pending activity" that we'd want to purge/ignore -- VPP installs? MDM commands?

@dantecatalfamo
Copy link
Member Author

@sgress454 MDM doesn't show up as upcoming at the moment AFAIK. There's a feature MDM is working on to make it work like that though. VPP installs use MDM commands as well

@dantecatalfamo
Copy link
Member Author

Code and tests LGTM. Not sure if there's a good way to test this locally without actually wiping a device? I'm also not sure what else might fall under the umbrella of "pending activity" that we'd want to purge/ignore -- VPP installs? MDM commands?

Yeah I tested it using a spare macbook air, I'm not aware of a way to fully test it without at least DEP enrolling a device

@dantecatalfamo dantecatalfamo merged commit 1ad76c5 into main Jan 21, 2025
32 checks passed
@dantecatalfamo dantecatalfamo deleted the 22353-abm-hosts-upcoming-activities branch January 21, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants