-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix upcoming activities for ABM-deleted hosts #25530
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25530 +/- ##
=======================================
Coverage 63.59% 63.60%
=======================================
Files 1619 1620 +1
Lines 154980 155066 +86
Branches 3987 3987
=======================================
+ Hits 98565 98635 +70
- Misses 48646 48659 +13
- Partials 7769 7772 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and tests LGTM. Not sure if there's a good way to test this locally without actually wiping a device? I'm also not sure what else might fall under the umbrella of "pending activity" that we'd want to purge/ignore -- VPP installs? MDM commands?
@sgress454 MDM doesn't show up as upcoming at the moment AFAIK. There's a feature MDM is working on to make it work like that though. VPP installs use MDM commands as well |
Yeah I tested it using a spare macbook air, I'm not aware of a way to fully test it without at least DEP enrolling a device |
#22353
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.See Changes files for more information.
SELECT *
is avoided, SQL injection is prevented (using placeholders for values in statements)