Cherry-Pick: Mention policy automation side effects of VPP token deletion/reassignment #25603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment (#25584) For #23115. Review requested from @marko-lisica per @noahtalerman's [response](#23115 (comment)) to @jmwatts's comment on the ticket. Skipping changes file as this is part of the larger feature and treated as an unreleased bug for change management purposes, assuming the copy revision looks good (or the copy revision looks good after more modifications). Will assign a dev reviewer once copy looks good, if we decide we want the copy here (vs. in docs). @marko-lisica set for review to confirm whether we need this/whether the copy looks good. @jmwatts set for review to confirm this is what she had in mind for feedback. Of note, deleting a VPP token does _not_ cancel pending installs since at that point the MDM command is already sent, so we don't need that verbiage here. ## Edit VPP token teams ### Before <img width="751" alt="image" src="https://github.com/user-attachments/assets/31154fed-abf5-4b36-9ebf-7d66dcab4694" /> ### After <img width="822" alt="image" src="https://github.com/user-attachments/assets/d95b68a6-3c0c-4576-9c41-9253be61e77b" /> ## Delete VPP token ### Before <img width="662" alt="image" src="https://github.com/user-attachments/assets/414dc1b2-6837-47a7-987b-439bd17be224" /> ### After <img width="665" alt="image" src="https://github.com/user-attachments/assets/423f1e11-3ecf-40cb-aa0d-479cef82623c" /> # Checklist for submitter - [ ] Manual QA for all new/changed functionality --------- Co-authored-by: Marko Lisica <83164494+marko-lisica@users.noreply.github.com>
ghernandez345
approved these changes
Jan 20, 2025
iansltx
deleted the
cherry-pick-tweak-vpp-token-modification-help-text
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rc-minor-fleet-v4.63.0 #25603 +/- ##
=========================================================
Coverage ? 63.58%
=========================================================
Files ? 1619
Lines ? 154928
Branches ? 3987
=========================================================
Hits ? 98515
Misses ? 48644
Partials ? 7769
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged into
mainin #25584.