Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to populate users and labels on list hosts endpoint #25621

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

dantecatalfamo
Copy link
Member

@dantecatalfamo dantecatalfamo commented Jan 20, 2025

#22464

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
    • fleetctl api -F populate_users=true -F populate_labels=true hosts
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 63.62%. Comparing base (12d8017) to head (2da5c48).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
server/service/transport.go 44.44% 8 Missing and 2 partials ⚠️
server/service/hosts.go 55.00% 6 Missing and 3 partials ⚠️
server/datastore/mysql/hosts.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25621      +/-   ##
==========================================
+ Coverage   63.59%   63.62%   +0.03%     
==========================================
  Files        1622     1622              
  Lines      155091   155162      +71     
  Branches     4000     4000              
==========================================
+ Hits        98633    98725      +92     
+ Misses      48686    48654      -32     
- Partials     7772     7783      +11     
Flag Coverage Δ
backend 64.48% <50.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantecatalfamo dantecatalfamo marked this pull request as ready for review January 21, 2025 21:48
@dantecatalfamo dantecatalfamo requested a review from a team as a code owner January 21, 2025 21:48
@dantecatalfamo
Copy link
Member Author

@lucasmrod Past tense on the first try!! 😁

Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment around authz check.

server/service/hosts.go Show resolved Hide resolved
Co-authored-by: Lucas Manuel Rodriguez <lucas@fleetdm.com>
@dantecatalfamo dantecatalfamo merged commit 347c65b into main Jan 22, 2025
35 checks passed
@dantecatalfamo dantecatalfamo deleted the 22464-list-hosts-populate-users-labels branch January 22, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants