Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Fix user management page overflow #25733

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Jan 23, 2025

Issue

For #25015

Description

  • Fix user management page overflowing for currently supported screens by hiding columns and setting max width to columns when overflowing
  • Add responsiveness to table and table headers down to 320
    • NOTE: A more global approach to table header responsiveness designs is ideal for maintainability and scalability and will require a refactor
  • Other part of this ticket: Fix empty integration container from overflowing page down to 768px

Other

  • Refactor to global fix to replace all locally hidden header cell left border to not display for view all host/action column (Note: this was added because hiding columns would make the current "border-right: none on whatever's the second to last column" really annoying and much easier to just say border-left: none of those action/view all host header)

Screenrecording of fix / Screenshot of improvement

Screen.Recording.2025-01-23.at.2.42.01.PM.mov
Screenshot 2025-01-24 at 9 30 53 AM

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

@RachelElysia RachelElysia requested a review from a team as a code owner January 23, 2025 19:45
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.61%. Comparing base (d893025) to head (3f28b3f).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25733   +/-   ##
=======================================
  Coverage   63.61%   63.61%           
=======================================
  Files        1624     1624           
  Lines      155309   155309           
  Branches     4003     4054   +51     
=======================================
  Hits        98797    98797           
  Misses      48714    48714           
  Partials     7798     7798           
Flag Coverage Δ
frontend 53.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple quick Q's. Main thing is making sure that all changes are documented so they can get QA'd.

Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RachelElysia RachelElysia merged commit 3060f45 into main Jan 24, 2025
11 checks passed
@RachelElysia RachelElysia deleted the 25015-overflow-bugs branch January 24, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants