Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illegal argument errors will no longer be logged at the ERROR level #25761

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

getvictor
Copy link
Member

For #25759

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.60%. Comparing base (ff43593) to head (22f253f).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25761      +/-   ##
==========================================
+ Coverage   63.59%   63.60%   +0.01%     
==========================================
  Files        1622     1624       +2     
  Lines      155023   155420     +397     
  Branches     3967     3967              
==========================================
+ Hits        98580    98857     +277     
- Misses      48662    48761      +99     
- Partials     7781     7802      +21     
Flag Coverage Δ
backend 64.46% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@getvictor getvictor marked this pull request as ready for review January 24, 2025 20:29
@getvictor getvictor requested a review from a team as a code owner January 24, 2025 20:29
@getvictor getvictor merged commit 89e314e into main Jan 27, 2025
36 checks passed
@getvictor getvictor deleted the victor/25759-illegal-argument-errors branch January 27, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants