Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Surface download URL for Fleet-maintained app when adding #25762

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Jan 24, 2025

Issue

For #25250

Description

  • Create "Software details" modal that shows details of FMA when adding the software to Fleet
    See ticket for more info and QA plan
  • +48 lines of basic test

Screenshot

Screenshot 2025-01-24 at 2 05 20 PM Truncated state for really long URL: Screenshot 2025-01-24 at 4 12 44 PM Empty state for URL (shouldn't happen): Screenshot 2025-01-24 at 4 08 46 PM

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.61%. Comparing base (382a2f1) to head (2ea7969).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25762   +/-   ##
=======================================
  Coverage   63.60%   63.61%           
=======================================
  Files        1624     1624           
  Lines      155419   155447   +28     
  Branches     4054     4010   -44     
=======================================
+ Hits        98856    98882   +26     
- Misses      48761    48763    +2     
  Partials     7802     7802           
Flag Coverage Δ
frontend 53.17% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RachelElysia
Copy link
Member Author

Will fix test monday, whatever reason using the truncated tooltip component breaks finding the URL in the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants