A couple naming improvements and cleanups #27321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 19, 2025 14:32
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27321 +/- ##
=======================================
Coverage 63.89% 63.89%
=======================================
Files 1731 1731
Lines 164610 164610
Branches 4507 4449 -58
=======================================
Hits 105175 105175
Misses 51266 51266
Partials 8169 8169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ghernandez345
approved these changes
Mar 20, 2025
sgress454
approved these changes
Mar 20, 2025
| RUNNING: `Running ${isPolicy ? "policy" : "query"}`, | ||
| FINISHED: `${isPolicy ? "Policy" : "Query"} finished`, | ||
| RUNNING: `Running ${resultsType}`, | ||
| FINISHED: `${resultsType[0].toUpperCase()}${resultsType.slice(1)} finished`, |
There was a problem hiding this comment.
or use Lodash upperFirst()
TsekNet
pushed a commit
to TsekNet/fleet
that referenced
this pull request
Mar 21, 2025
## For fleetdm#24950 - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #24950