Skip to content

Fixes 29044: UI bug due to missing style for tooltip. #29556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

juan-fdz-hawa
Copy link
Contributor

@juan-fdz-hawa juan-fdz-hawa commented May 28, 2025

For #29044

Fixed bug with the 'Observers can run this query' tooltip on the queries page due to missing styling rules.

https://drive.google.com/file/d/1EmVPwOR6r8NmNKdmc7co8HLqHiGnErsS/view?usp=sharing

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Manual QA for all new/changed functionality

Fixed bug with the 'Observers can run this query' tooltip on the queries page due to missing styling rules.
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.21%. Comparing base (6d03dc3) to head (aaff019).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29556      +/-   ##
==========================================
+ Coverage   64.19%   64.21%   +0.02%     
==========================================
  Files        1850     1850              
  Lines      180028   180046      +18     
  Branches     5208     5288      +80     
==========================================
+ Hits       115563   115624      +61     
+ Misses      55385    55342      -43     
  Partials     9080     9080              
Flag Coverage Δ
frontend 53.96% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juan-fdz-hawa juan-fdz-hawa linked an issue May 29, 2025 that may be closed by this pull request
Copy link
Contributor

@jacobshandling jacobshandling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on @juan-fdz-hawa – here's how we want to go about this kind of thing: main...29044-jacob

TooltipWrapper now supports every version of tooltip we use in the UI with configuration through its props and no custom styling required : )

@juan-fdz-hawa
Copy link
Contributor Author

Thanks for taking this on @juan-fdz-hawa – here's how we want to go about this kind of thing: main...29044-jacob

TooltipWrapper now supports every version of tooltip we use in the UI with configuration through its props and no custom styling required : )

Thanks, done in aaff019.

@jacobshandling jacobshandling self-requested a review May 30, 2025 22:18
Copy link
Contributor

@jacobshandling jacobshandling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@juan-fdz-hawa juan-fdz-hawa merged commit ec42e2d into main May 30, 2025
15 checks passed
@juan-fdz-hawa juan-fdz-hawa deleted the juan-29044-wrong-tooltip-obs-can-run branch May 30, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queries page: Wrong tooltip styles for "Observer can run" icon
2 participants