-
Notifications
You must be signed in to change notification settings - Fork 617
Fixes 29044: UI bug due to missing style for tooltip. #29556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed bug with the 'Observers can run this query' tooltip on the queries page due to missing styling rules.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29556 +/- ##
==========================================
+ Coverage 64.19% 64.21% +0.02%
==========================================
Files 1850 1850
Lines 180028 180046 +18
Branches 5208 5288 +80
==========================================
+ Hits 115563 115624 +61
+ Misses 55385 55342 -43
Partials 9080 9080
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on @juan-fdz-hawa – here's how we want to go about this kind of thing: main...29044-jacob
TooltipWrapper
now supports every version of tooltip we use in the UI with configuration through its props and no custom styling required : )
Thanks, done in aaff019. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
For #29044
Fixed bug with the 'Observers can run this query' tooltip on the queries page due to missing styling rules.
https://drive.google.com/file/d/1EmVPwOR6r8NmNKdmc7co8HLqHiGnErsS/view?usp=sharing
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.See Changes files for more information.