use a check for dir existence that doesn't set exit code 1 if the dir doesn't exist #29952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #29952 +/- ##
==========================================
+ Coverage 64.17% 65.05% +0.87%
==========================================
Files 1861 1241 -620
Lines 181886 165290 -16596
Branches 5217 0 -5217
==========================================
- Hits 116729 107522 -9207
+ Misses 55972 48612 -7360
+ Partials 9185 9156 -29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iansltx
reviewed
Jun 12, 2025
iansltx
reviewed
Jun 12, 2025
iansltx
reviewed
Jun 12, 2025
docs/Contributing/product-groups/orchestration/understanding-host-vitals.md
Outdated
Show resolved
Hide resolved
iansltx
reviewed
Jun 12, 2025
| if _, ok := s.pathsCreated[pathname]; !ok { | ||
| s.Writef("mkdir -p %s", pathname) | ||
| s.pathsCreated[pathname] = struct{}{} | ||
| } | ||
| s.Writef(`[ -d "%s" ] && /bin/ln -h -f -s -- "%s" "%s"`, pathname, source, target) |
There was a problem hiding this comment.
Suggested change
| s.Writef(`[ -d "%s" ] && /bin/ln -h -f -s -- "%s" "%s"`, pathname, source, target) | |
| s.Writef(`/bin/ln -h -f -s -- "%s" "%s"`, pathname, source, target) |
@jahzielv now that we make the dir ahead of time, we can indeed drop this, based on looking back at the last time this was changed, in #25901.
|
test failures are unrelated |
iansltx
reviewed
Jun 13, 2025
|
merging
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.