-
Notifications
You must be signed in to change notification settings - Fork 727
Add Spotify as macOS Fleet-maintained app #35336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Introduces Spotify as a maintained app for macOS, including input and output JSON definitions, install/uninstall scripts, an icon component, and the app icon image. Updates the apps.json to list Spotify with relevant metadata and description.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #35336 +/- ##
==========================================
- Coverage 66.23% 66.08% -0.16%
==========================================
Files 2109 2089 -20
Lines 179221 176434 -2787
Branches 7442 7381 -61
==========================================
- Hits 118712 116593 -2119
+ Misses 49627 49160 -467
+ Partials 10882 10681 -201
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@georgekarrv & @marko-lisica this is ready for review! |
fbe18d6
|
Fixed a conflict. The check is failing on an unrelated FMA. Ready for re-review. |
Introduces Spotify as a maintained app for macOS, including input and output JSON definitions, install/uninstall scripts, an icon component, and the app icon image. Updates the apps.json to list Spotify with relevant metadata and description.
Related issue: Resolves #
Checklist for submitter
If some of the following don't apply, delete the relevant line.
Changes file added for user-visible changes in
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Input data is properly validated,
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes
Testing
Added/updated automated tests
Where appropriate, automated tests simulate multiple hosts and test for host isolation (updates to one hosts's records do not affect another)
QA'd all new/changed functionality manually
For unreleased bug fixes in a release candidate, one of:
Database migrations
COLLATE utf8mb4_unicode_ci).New Fleet configuration settings
If you didn't check the box above, follow this checklist for GitOps-enabled settings:
fleetctl generate-gitopsfleetd/orbit/Fleet Desktop
runtime.GOOSis used as needed to isolate changes