Skip to content

Conversation

@allenhouchins
Copy link
Member

Introduces Spotify as a maintained app for macOS, including input and output JSON definitions, install/uninstall scripts, an icon component, and the app icon image. Updates the apps.json to list Spotify with relevant metadata and description.

Related issue: Resolves #

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

  • If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes

Testing

For unreleased bug fixes in a release candidate, one of:

  • Confirmed that the fix is not expected to adversely impact load test results
  • Alerted the release DRI if additional load testing is needed

Database migrations

  • Checked schema for all modified table for columns that will auto-update timestamps during migration.
  • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
  • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).

New Fleet configuration settings

  • Setting(s) is/are explicitly excluded from GitOps

If you didn't check the box above, follow this checklist for GitOps-enabled settings:

  • Verified that the setting is exported via fleetctl generate-gitops
  • Verified the setting is documented in a separate PR to the GitOps documentation
  • Verified that the setting is cleared on the server if it is not supplied in a YAML file (or that it is documented as being optional)
  • Verified that any relevant UI is disabled when GitOps mode is enabled

fleetd/orbit/Fleet Desktop

  • Verified compatibility with the latest released version of Fleet (see Must rule)
  • If the change applies to only one platform, confirmed that runtime.GOOS is used as needed to isolate changes
  • Verified that fleetd runs on macOS, Linux and Windows
  • Verified auto-update works from the released version of component to the new version (see tools/tuf/test)

Introduces Spotify as a maintained app for macOS, including input and output JSON definitions, install/uninstall scripts, an icon component, and the app icon image. Updates the apps.json to list Spotify with relevant metadata and description.
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.08%. Comparing base (c1b5d18) to head (aea0f49).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35336      +/-   ##
==========================================
- Coverage   66.23%   66.08%   -0.16%     
==========================================
  Files        2109     2089      -20     
  Lines      179221   176434    -2787     
  Branches     7442     7381      -61     
==========================================
- Hits       118712   116593    -2119     
+ Misses      49627    49160     -467     
+ Partials    10882    10681     -201     
Flag Coverage Δ
frontend 53.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@allenhouchins allenhouchins marked this pull request as ready for review November 7, 2025 04:29
@allenhouchins allenhouchins requested a review from a team as a code owner November 7, 2025 04:29
@allenhouchins
Copy link
Member Author

@georgekarrv & @marko-lisica this is ready for review!

@allenhouchins allenhouchins requested review from georgekarrv and removed request for mostlikelee November 7, 2025 04:30
georgekarrv
georgekarrv previously approved these changes Nov 10, 2025
ghernandez345
ghernandez345 previously approved these changes Nov 11, 2025
@allenhouchins
Copy link
Member Author

Fixed a conflict. The check is failing on an unrelated FMA. Ready for re-review.

@allenhouchins allenhouchins requested review from georgekarrv and ghernandez345 and removed request for mostlikelee November 12, 2025 03:42
@allenhouchins allenhouchins requested review from a team and removed request for eashaw, georgekarrv and ghernandez345 November 15, 2025 04:35
@allenhouchins allenhouchins marked this pull request as draft November 15, 2025 18:44
@allenhouchins allenhouchins marked this pull request as ready for review November 16, 2025 04:46
@allenhouchins allenhouchins changed the title Add Spotify as macOS FMA Add Spotify as macOS Fleet-maintained app Nov 17, 2025
@allenhouchins allenhouchins merged commit 6ee299d into main Nov 17, 2025
20 checks passed
@allenhouchins allenhouchins deleted the allenhouchins-add-spotify branch November 17, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants