-
Notifications
You must be signed in to change notification settings - Fork 590
feat: BottomSheet.fullscreen and CupertinoActivityIndicator.progress
#5793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors control properties for better clarity and adds new features to several controls. The changes include renaming properties to be more concise and intuitive, expanding BottomSheet capabilities, and adding progress tracking to CupertinoActivityIndicator.
- Renamed
date_picker_entry_modetoentry_modein DatePicker and DateRangePicker - Renamed
enable_dragtodraggableandscroll_controlledtoscrollablein BottomSheet - Added
fullscreenproperty to BottomSheet for filling the entire page - Added
progressproperty to CupertinoActivityIndicator for partial reveal functionality - Made
DatePickerEntryModeChangeEvent.entry_modenon-optional for type safety
Reviewed Changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/python/packages/flet/src/flet/controls/material/date_range_picker.py | Renamed date_picker_entry_mode to entry_mode and updated documentation references |
| sdk/python/packages/flet/src/flet/controls/material/date_picker.py | Renamed date_picker_entry_mode to entry_mode, made event field non-optional, updated documentation |
| sdk/python/packages/flet/src/flet/controls/material/bottom_sheet.py | Renamed properties, added fullscreen feature, improved documentation with example formatting |
| sdk/python/packages/flet/src/flet/controls/cupertino/cupertino_activity_indicator.py | Added progress property with validation and updated documentation structure |
| sdk/python/packages/flet/integration_tests/controls/material/test_date_range_picker.py | Updated test to use new entry_mode property name |
| sdk/python/packages/flet/integration_tests/controls/cupertino/test_cupertino_activity_indicator.py | Added tests for basic and progress functionality |
| sdk/python/packages/flet/integration_tests/controls/cupertino/golden/macos/cupertino_activity_indicator/progress.png | Added golden test image for progress feature |
| sdk/python/packages/flet/integration_tests/controls/cupertino/golden/macos/cupertino_activity_indicator/basic.png | Added golden test image for basic functionality |
| sdk/python/packages/flet/docs/controls/bottomsheet.md | Added fullscreen example section to documentation |
| sdk/python/examples/controls/date_range_picker/basic.py | Updated type annotation for dismissal handler |
| sdk/python/examples/controls/cupertino_activity_indicator/progress.py | Added example demonstrating progress property with slider control |
| sdk/python/examples/controls/bottom_sheet/fullscreen.py | Added example demonstrating fullscreen bottom sheet feature |
| sdk/python/examples/controls/bottom_sheet/basic.py | Removed redundant overlay.append, added if name guard |
| packages/flet/lib/src/controls/date_range_picker.dart | Updated property name from date_picker_entry_mode to entry_mode |
| packages/flet/lib/src/controls/date_picker.dart | Updated property name from date_picker_entry_mode to entry_mode |
| packages/flet/lib/src/controls/cupertino_activity_indicator.dart | Implemented progress property with conditional rendering logic |
| packages/flet/lib/src/controls/bottom_sheet.dart | Implemented renamed properties and fullscreen functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying flet-docs with
|
| Latest commit: |
5389528
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://add1a44b.flet-docs.pages.dev |
| Branch Preview URL: | https://fullscreen-bottom-sheet.flet-docs.pages.dev |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Additional notes:
|
Fix #5127
Example
Summary by Sourcery
Enable full-height BottomSheet and partial spinner control in CupertinoActivityIndicator, harmonize related property names, and refresh docs, examples, and tests accordingly
New Features:
Enhancements:
Documentation:
Tests: