fix(flet-map): PolylineLayer not showing up in UI
#5794
+32
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es` and `PolylineMarker`
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Deploying flet-docs with
|
| Latest commit: |
0fd9108
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a8c25517.flet-docs.pages.dev |
| Branch Preview URL: | https://fix-polylinelayer.flet-docs.pages.dev |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR includes documentation improvements for enum values and a bug fix in the polyline layer control. The changes enhance code clarity and correct incorrect references.
- Documentation added/improved for
ImageRepeatandVisualDensityenum values - Fixed incorrect references in
polyline_layer.dartfrom "polygons"/"PolygonMarker" to "polylines"/"PolylineMarker" - Minor formatting cleanup in type alias documentation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
sdk/python/packages/flet/src/flet/controls/types.py |
Added documentation strings for ImageRepeat enum values and improved formatting of VisualDensity enum documentation |
sdk/python/packages/flet-map/src/flutter/flet_map/lib/src/polyline_layer.dart |
Fixed incorrect children selector and type check from "polygons"/"PolygonMarker" to "polylines"/"PolylineMarker" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Please check copilot comments here: https://github.com/flet-dev/flet/pull/5794/files#diff-dd984269d51a00ebf6d86e01e0dc5cd02cfd6f00a9451245045712142894270f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5776
Summary by Sourcery
Fix polyline rendering issue in Flet map and standardize enum documentation
Bug Fixes:
Enhancements: