Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add serde support #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: Add serde support #24

wants to merge 1 commit into from

Conversation

landaire
Copy link

This PR adds serde support gated behind the serde feature flag, allowing public structures this library provides to be serialized.

@landaire
Copy link
Author

landaire commented Jun 28, 2023

In this current state I don't think this PR should be merged as there's a little bit of style cleanup needed (some things don't need to be mut, etc.), docs, and tests should probably be added.

I wanted to get this PR submitted even in this state though to gauge interest in bringing this into project before making those changes. I saw in #5 that @mitsuhiko at least may have interest in this but it wasn't 100% clear to me.

@flier flier changed the title Add serde support WIP: Add serde support Jul 28, 2023
@flier
Copy link
Owner

flier commented Jul 28, 2023

In this current state I don't think this PR should be merged as there's a little bit of style cleanup needed (some things don't need to be mut, etc.), docs, and tests should probably be added.

I wanted to get this PR submitted even in this state though to gauge interest in bringing this into project before making those changes. I saw in #5 that @mitsuhiko at least may have interest in this but it wasn't 100% clear to me.

Sure, remove the WIP in title when you ready :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants