Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unreachable panic when parsing export table #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Orycterope
Copy link

Found this issue when fuzzing the crate.

The export symbol flag kind uses that last two bits of flags, and therefore can take 4 values. Only 3 are officially defined in the ExportSymbolKind enum.

Malformed macho files can define a symbol kind of 0b11 and will cause this crate to panic when parsing them.

Avoid panicking, and return a new error kind instead.

Found this issue when fuzzing the crate.

The export symbol flag kind uses that last two bits of `flags`, and therefore
can take 4 values. Only 3 officially defined in the ExportSymbolKind enum.

Malformed macho files can define a symbol kind of 0b11 and will cause this
crate to panic when parsing them.

Avoid panicking, and return a new error kind instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant