Less generic type checks #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this improves performance ~15%
tomhooijenga
commented
Oct 2, 2020
|
|
||
| export const isSet = (payload: any): payload is Set<any> => | ||
| getType(payload) === 'Set'; | ||
| payload instanceof Set; | ||
|
|
||
| export const isSymbol = (payload: any): payload is symbol => | ||
| getType(payload) === 'Symbol'; |
There was a problem hiding this comment.
The linter would not let me replace this with typeof payload === 'symbol'
|
Awesome! Thanks for this great PR. |
Skn0tt
approved these changes
Oct 3, 2020
|
@allcontributors add tomhooijenga code |
|
I've put up a pull request to add @tomhooijenga! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to #68.
Performance should increase 15 to 20%.