Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not evaluate isClassArityUsageDisabled on every serialize/des… #157

Conversation

s-gelazevicius
Copy link
Contributor

@s-gelazevicius s-gelazevicius commented Oct 11, 2024

…erialize function call

I noticed degraded performance after upgrading to new version.
isClassArityUsageDisabled was evaluated on every serialize/deserialize function call.
This is quite expensive because map is created every time, then get and exist is called.
This can be observed in attached flamegraph:

image

@novakov-alexey
Copy link
Collaborator

@s-gelazevicius thank you for this PR.

Maybe even move that value into the object CaseClassSerializer, since it is just env variable check which can be checked on startup?

@s-gelazevicius
Copy link
Contributor Author

@s-gelazevicius thank you for this PR.

Maybe even move that value into the object CaseClassSerializer, since it is just env variable check which can be checked on startup?

Done.

@novakov-alexey novakov-alexey merged commit bd076b2 into flink-extended:master Oct 11, 2024
7 checks passed
@s-gelazevicius
Copy link
Contributor Author

@novakov-alexey Thank you for quick response, maybe you know when new version with a fix can be released

@novakov-alexey
Copy link
Collaborator

@s-gelazevicius I think I will release it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants